Hi!

Thanks for a great extension. I'm using Imgen with the watermark plugin, and hacked a few other extensions so they will display the watermarked images. I've run into one problem, though, and I'm hoping someone will have an idea as to how to fix it.

My client has 1,000+ K2 articles, many of which have photo galleries. Unfortunately most of the photo file names have spaces in them, like this: "One Harbourgreen Place - 1169 W. Cordova 2.jpg"

The K2 articles use Simple Image Gallery Pro to display the images, and it replaces the spaces with "%20". This works fine when displaying the original images in a lightbox, but not the watermarked ones.

Here's a sample of an URL generated by the Gallery plugin:



It displays fine.

When the same URL is modified to display the watermarked version (also using %20 instead of spaces) the watermark plugin doesn't work. Here's a sample of a modified URL:



Any gallery without a space in the filename loads fine... Any idea as to what I can do to help the plugin work with these spaced filenames? Unfortunately there are hundreds of images, each in their own gallery folder, so renaming them to remove the spaces is not an option.

Cheers,
Chris

P.S. If I manually rename an image, it displays fine - here's an example of a working watermarked URL:

I will have a look at this, hopefully there is a solution. But none of the urls you supplied work, I just get a 404 component not found error.

Thanks Susan.

No, the links don't work - I substituted the client's real domain name with "www.clientdomain.com" in the sample links (since the site isn't public yet and the client wants to keep it private until it's officially launched.)

Regards,
Chris

Hi Susan,

I installed Imgen and the watermark plugin on another site and was able to easily reproduce the problem. I simply uploaded an image with spaces in the name and then tried to use Imgen as usual to create the watermarked version.

Here are some live, working links that you can test:

Image name:
facebook 180 540.gif (note the spaces)

Working link:


Watermarked version, not working:


Even though I'm passing a valid source link via the "&img=..." parameter, Imgen can't handle it for some reason. I know that spaces in file names isn't a good idea in general, but obviously many sites have inexperienced users who don't know any better. Since other plugins can still work with the same images (such as Simple Image Gallery Pro) I'm sure there's a solution but it's beyond my PHP skills Maybe an image with spaces in it could be automatically copied to a new file that has underscores instead of spaces?

Cheers,
Chris

A friend of mine was able to solve this problem by remarking out a line of code. All the watermarked images on my client's site now display perfectly, even the ones with spaces in the filenames I'll paste his entire response below in case anyone else needs it in future. Perhaps this line could be removed from the next version of Imgen (or at least kept in but revised somehow.)

Cheers,
Chris

Thanks for this - the thing is that the official PHP manual says that spaces should be encoded as '%20' when using the getimagesize() function, but I think you are right, this is only when the image path is a full url rather than a physical path. I have noticed before that it causes problems then.

It should not be difficult to put this right in a new release.